allow get_dataref with DONTTOUCHDATA

PDLPorters · Oct 24, 2024 · ad716c5 · ad716c5
1 parent b1f2d79
commit ad716c5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/Basic/Core/Core.xs b/Basic/Core/Core.xs
@@ -1043,8 +1043,6 @@ SV *
 get_dataref(self)
 	pdl *self
 	CODE:
-	if(self->state & PDL_DONTTOUCHDATA)
-	  croak("Trying to get dataref to magical (mmaped?) pdl");
 	PDLDEBUG_f(printf("get_dataref %p\n", self));
 	pdl_barf_if_error(pdl_make_physical(self));
 	if (!self->datasv) {

diff --git a/Changes b/Changes
@@ -12,6 +12,7 @@
 - IO::HDF remove VNAMELENMAX and Vinquire as obsoleted by recent HDF4 (#500) - thanks @a-shahba for report
 - IO::FlexRaw::mapflex stop allocating memory (#501) - thanks @vitstradal for report
 - add Primitive::approx_artol
+- get_dataref now works even with DONTTOUCHDATA which is really about allocation
 
 2.093 2024-09-29
 - PDL.set_datatype now doesn't physicalise input, PDL.convert_type does