no inflate size-1 dims on [phys]

PDLPorters · Feb 24, 2024 · db71519 · db71519
1 parent b7931db
commit db71519
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Basic/Core/pdlbroadcast.c b/Basic/Core/pdlbroadcast.c
@@ -245,7 +245,7 @@ pdl_error pdl_dim_checks(
         /* Dimensional promotion when number of dims is less than required: */
         ind_sz = ind_sizes[ind_id] = 1;
       if (load_only && creating[i]) continue;
-      if (ind_sz == -1 || (j < ndims && ind_sz == 1)) {
+      if (ind_sz == -1 || (!(flags & PDL_PARAM_ISPHYS) && j < ndims && ind_sz == 1)) {
         ind_sizes[ind_id] = dims[j];
         continue;
       }

diff --git a/t/core.t b/t/core.t
@@ -170,6 +170,7 @@ subtest 'dim compatibility' => sub {
     [\&polyroots, [ones(2), zeroes(2), zeroes(1), zeroes(1)], 2, [-1], '[phys] output=[1]'],
     [\&polyroots, [ones(2), zeroes(1), zeroes(), zeroes(1)], 2, qr/dim has size 1/, '[phys] output=[2] mismatch'],
     [\&polyroots, [ones(2), zeroes(1), zeroes(1), zeroes(1)], 2, qr/dim has size 1/, '[phys] output=[2] mismatch'],
+    [\&polyroots, [ones(2), zeroes(2), zeroes(2), zeroes(2)], 2, qr/dim has size 2/, '[phys] output=[2] mismatch'],
     [\&polyroots, [ones(2), zeroes(2), zeroes(1,2), zeroes(1)], 2, qr/implicit dim/, '[phys] one outputs=[1,2],[1] no promote output implicit dims'],
     [\&polyroots, [ones(2), zeroes(2,2), zeroes(1,2), zeroes(1,2)], 2, [[-1],[-1]], '[phys] output=[1,2] ok broadcast over input'],
     [\&polyroots, [ones(2), zeroes(2,2), zeroes(1), zeroes(1,2)], 2, qr/implicit dim/, '[phys] output=[1,2] not ok broadcast over output implicit dim'],