Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIS::Proj - Use Alien::proj #456

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

shawnlaffan
Copy link
Contributor

And add its bin dirs to the path on Windows
so it can function.

Done using pp_addbegin as pp_addpm happens
after the dynaload call, which is too late.

Updates #441

And add its bin dirs to the path on Windows
so it can function.

Done using pp_addbegin as pp_addpm happens
after the dynaload call, which is too late.
@coveralls
Copy link

Coverage Status

coverage: 28.865% (-0.05%) from 28.91% when pulling d33e07e on shawnlaffan:proj_on_windows into d144131 on PDLPorters:master.

@shawnlaffan
Copy link
Contributor Author

Would be good to get this reviewed and/or committed.

If the build detects Alien::proj and it then unconditionally adds the proj components. These then fail, which means one cannot install or update PDL on windows if Alien::proj is already installed (unless the tests are ignored or skipped, of course).

@mohawk2 mohawk2 merged commit 2effb17 into PDLPorters:master Jan 29, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants