Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More stuff for the DeveloperGuide, as suggested in GitHub#481 #486

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

HaraldJoerg
Copy link
Contributor

  • Basic/Pod/DeveloperGuide.pod: Delete the sections "Access to PDL's configuration" and "Ingesting an external PDL module". Document $::PP_VERBOSE and $PDL::Graphics::TriD::verbose. Add a section "Generating a Stack Trace" taken from GitHub issue better document debug macros #393. Add some more mappings to the package->source file table.

  • Basic/PDL.pm: Link to the Developer Guide under LANGUAGE DOCUMENTATION.

  • Basic/Pod/FAQ.pod: Link to the Developer Guide in Q: 3.5.

  • Basic/Pod/QuickStart.pod: Link to the Developer Guide. Also remove a phrase "until recently" which was recent ... in 1998, and don't mention HTML copies of the documentation which are no longer generated (and https://perldoc.perl.org exists).

@coveralls
Copy link

Coverage Status

coverage: 32.689% (+0.005%) from 32.684%
when pulling bcb9951 on HaraldJoerg:devdoc_june
into f42205b on PDLPorters:master.

Copy link
Member

@mohawk2 mohawk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Once it's updated and merged, could I ask you to comment on the open issues that you've pulled info from? I can then update them to show the points that have been incorporated.

Basic/Pod/DeveloperGuide.pod Outdated Show resolved Hide resolved
Basic/Pod/DeveloperGuide.pod Outdated Show resolved Hide resolved
Basic/Pod/DeveloperGuide.pod Show resolved Hide resolved
Basic/Pod/QuickStart.pod Show resolved Hide resolved
adjusted after review:

* Basic/Pod/DeveloperGuide.pod:
  Delete the sections "Access to PDL's configuration" and
  "Ingesting an external PDL module".
  Document $::PP_VERBOSE and $PDL::Graphics::TriD::verbose.
  Add a section "Generating a Stack Trace" taken from GitHub issue PDLPorters#393.
  Add some more mappings to the package->source file table.

* Basic/PDL.pm: Link to the Developer Guide under LANGUAGE
  DOCUMENTATION.

* Basic/Pod/FAQ.pod: Link to the Developer Guide in Q: 3.5.

* Basic/Pod/QuickStart.pod: Link to the Developer Guide. Also
  remove a phrase "until recently" which was recent ... in 1998, and
  don't mention HTML copies of the documentation which are no longer
  generated (and https://perldoc.perl.org exists).

Changes according to mohawk2's review:

* Mention $PDL::verbose and PDL::debug.
* Adapt the section to organize commit to current best practice
  "one commit per small, meaningfil change"
* Delete modules outside the repository from the module->file table
* Add a line describing pdldoc
@coveralls
Copy link

Coverage Status

coverage: 32.727% (-0.2%) from 32.883%
when pulling 3f5788e on HaraldJoerg:devdoc_june
into 4e4a7d7 on PDLPorters:master.

@mohawk2
Copy link
Member

mohawk2 commented Aug 1, 2024

Thank you! Are you happy for me to merge this, or is there more you'd like to change?

@mohawk2 mohawk2 merged commit b1d5e88 into PDLPorters:master Aug 1, 2024
68 of 69 checks passed
@mohawk2
Copy link
Member

mohawk2 commented Aug 1, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants