Fix wfits multi-line HISTORY field #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for this! I've taken the liberty of "convert[ing it] to draft" (under the Reviewers section, top right - I had to look up how). When it's not a draft anymore, the "Ready for review" button is in the "Checks" box at the bottom. For the test, could you please make files in a temporary directory, that gets auto-deleted? Then you don't need to manually |
|
Also, it may be helpful for you if you rebase this to current |
mohawk2
force-pushed
the
wfits-multiline-history
branch
from
e744c78
to
150ea00
Compare
This adds one passing and one (currently) failing test with multi-line HISTORY strings in the header.
mohawk2
force-pushed
the
wfits-multiline-history
branch
2 times, most recently
from
4c525ed
to
1d983cf
Compare
mohawk2
force-pushed
the
wfits-multiline-history
branch
from
1d983cf
to
74e0566
Compare
mohawk2
force-pushed
the
wfits-multiline-history
branch
from
74e0566
to
bbb04a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP! This just adds one passing and one failing test illustrating the problem in #488.