Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
  • Loading branch information
rodrigoprimo and jrfnl authored Dec 19, 2024
1 parent 6bb661d commit a6ddc1e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,8 @@ class Config
* - Keys: lowercase version of the generator name.
* - Values: name of the generator PHP class.
*
* Note: once support for PHP < 5.6 is dropped, this property should be refactored into a class
* constant.
* {@internal Once support for PHP < 5.6 is dropped, this property should be refactored into a class
* constant.}
*
* @var array<string, string>
*/
Expand Down Expand Up @@ -1256,7 +1256,7 @@ public function processLongArgument($arg, $pos)
if (isset(self::$validGenerators[$lowerCaseGeneratorName]) === false) {
$validOptions = implode(', ', array_values(self::$validGenerators));
$error = sprintf(
'ERROR: "%s" is not a valid generator. Valid options are: %s.'.PHP_EOL.PHP_EOL,
'ERROR: "%s" is not a valid generator. The following generators are supported: %s.'.PHP_EOL.PHP_EOL,
$generatorName,
$validOptions
);
Expand Down
2 changes: 1 addition & 1 deletion tests/Core/Config/GeneratorArgTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ final class GeneratorArgTest extends TestCase
/**
* Ensure that the generator property is set when the parameter is passed a valid value.
*
* @param string $argumentValue Generator name passed in the command line.
* @param string $argumentValue Generator name passed on the command line.
* @param string $expectedPropertyValue Expected value of the generator property.
*
* @dataProvider dataValidGeneratorNames
Expand Down

0 comments on commit a6ddc1e

Please sign in to comment.