Squiz/ScopeKeywordSpacing: add more defensive coding + extra tests #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/squiz-scopekeywordspacing-defensive-coding
branch
from
96cfd24 to
f75abc3
Compare
This was referenced Dec 13, 2023
... to allow for adding additional test case files for this sniff.
When the sniff would encounter a parse error/be run during live coding, the sniff could trigger an `Undefined array key` notice for the use of `$stackPtr + 2`. Fixed now by bowing out early if the keyword is found at the end of a file. Includes additional tests.
This is already handled correctly, the tests just safeguards this.
jrfnl
force-pushed
the
feature/squiz-scopekeywordspacing-defensive-coding
branch
from
f75abc3 to
1a046ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Squiz/ScopeKeywordSpacing: rename the test case file
... to allow for adding additional test case files for this sniff.
Squiz/ScopeKeywordSpacing: add more defensive coding
When the sniff would encounter a parse error/be run during live coding, the sniff could trigger an
Undefined array keynotice for the use of$stackPtr + 2.Fixed now by bowing out early if the keyword is found at the end of a file.
Includes additional tests.
Squiz/ScopeKeywordSpacing: add extra tests with static in a union type
This is already handled correctly, the tests just safeguards this.
Suggested changelog entry
Types of changes