Tokenizer/PHP: prevent an "Undefined array key" notice during live coding #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding During live coding or for code containing a parse error, it was possible for the tokenizer to run into an `Undefined array key "parenthesis_closer"` error when trying to verify arrow functions. As this error happens during the tokenization, this resulted in PHPCS silently not scanning the file - without even showing the error notice. Fixed now. Includes tests.
fredden
approved these changes
Jan 10, 2025
jrfnl
deleted the
feature/tokenizer-php-prevent-undefined-array-key-notice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During live coding or for code containing a parse error, it was possible for the tokenizer to run into an
Undefined array key "parenthesis_closer"error when trying to verify arrow functions.As this error happens during the tokenization, this resulted in PHPCS silently not scanning the file - without even showing the error notice.
Fixed now.
Includes tests.
Suggested changelog entry
Tokenizer/PHP: prevent a potential error notice during live coding for unfinished arrow functions