Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(font): add default asian font name #2714

Merged
merged 6 commits into from
Jan 15, 2025
Merged

feat(font): add default asian font name #2714

merged 6 commits into from
Jan 15, 2025

Conversation

jnlin
Copy link
Contributor

@jnlin jnlin commented Dec 6, 2024 •
edited
Loading

Description

Allow PHPWord to set Latin / Asian font separately

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@coveralls
Copy link

coveralls commented Dec 6, 2024 •
edited
Loading

Coverage Status

coverage: 96.947% (+0.002%) from 96.945%
when pulling b1ba078 on WritePath:asian-font
into f9da10e on PHPOffice:master.

@Progi1984 Progi1984 self-assigned this Jan 11, 2025
Progi1984
Progi1984 reviewed Jan 13, 2025
View reviewed changes
src/PhpWord/PhpWord.php Outdated Show resolved Hide resolved
Progi1984
Progi1984 reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnlin Good job. Could you add unit tests for your modifications in class PhpWord ?

After that, it will be good.

@jnlin @Progi1984
fix: specify the return value type
d907fff 
Co-authored-by: Progi1984 <progi1984@gmail.com>
@jnlin
Copy link
Contributor Author

jnlin commented Jan 15, 2025

@jnlin Good job. Could you add unit tests for your modifications in class PhpWord ?

After that, it will be good.

Unit test added

@Progi1984 Progi1984 added this to the 1.4.0 milestone Jan 15, 2025
@Progi1984 Progi1984 merged commit 337dc27 into PHPOffice:master Jan 15, 2025
30 checks passed
@Progi1984
Copy link
Member

@jnlin Thanks for your contribution 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 left review comments

Assignees

@Progi1984 Progi1984

Labels
Change Request
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jnlin @coveralls @Progi1984