Feat: Added Epub3 writer support #2724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…composer.lock (in support of PR PHPOffice#2722 : Autoload)
|
@Progi1984 can you please review this PR? |
|
And also look at this checking procedure I was running in local. There are some deprecated unit tests. What to do about that? |
|
@Sambit003 Could you implement basic Text and Image Elements ? No need styles. I just want that Epub generated contains image and text. After that, I can review. |
Sure. Then i'm removing the part of the style. Already the text and image element part is there. Again I will give it a thorough check. |
|
Let the basic style you made. It's perfect in a first time. |
Yeah okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented ePub3 writer support
Fixes #55
/claim #55
Checklist: