Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize handle_transaction #93

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Optimize handle_transaction #93

merged 3 commits into from
Oct 25, 2024

Conversation

panleone
Copy link
Member

Optimize handle_transaction

  • first commit: Avoid calling the copy assignment operator on Note struct
  • second commit: Avoid calling the copy assignment operator on UnifiedFullViewingKey struct

@panleone panleone added the enhancement New feature or request label Oct 25, 2024
@panleone panleone requested a review from Duddino October 25, 2024 07:10
@panleone panleone self-assigned this Oct 25, 2024
@Duddino Duddino mentioned this pull request Oct 25, 2024
Merged
Duddino
Duddino approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.
To be really pendantic, Note::clone is a no-op because all the fields boil down to Copy structs, but it's good to not rely on this kind of assumptions.
UnifiedFullViewingKey has a String inside

@Duddino Duddino merged commit 3400f21 into PIVX-Labs:master Oct 25, 2024
1 check passed
@panleone panleone deleted the avoid_copy branch November 21, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duddino Duddino Duddino approved these changes

Assignees

@panleone panleone

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panleone @Duddino