Refactor: Detect proxy environment variable on daemon start (#358)

Signed-off-by: xiafeng <xiafeng.li@foxmail.com>
PKUHPC · Nov 12, 2024 · 1273f69 · 1273f69
1 parent b4b364c
commit 1273f69
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 0 deletions.
diff --git a/src/CraneCtld/CraneCtld.cpp b/src/CraneCtld/CraneCtld.cpp
@@ -785,6 +785,7 @@ int StartServer() {
     CRANE_ERROR("Unable to set file descriptor limits to {}", file_max);
     std::exit(1);
   }
+  util::os::CheckProxyEnvironmentVariable();
 
   CreateFolders();
 

diff --git a/src/Craned/Craned.cpp b/src/Craned/Craned.cpp
@@ -646,6 +646,7 @@ void StartServer() {
 
   // Set FD_CLOEXEC on stdin, stdout, stderr
   util::os::SetCloseOnExecOnFdRange(STDIN_FILENO, STDERR_FILENO + 1);
+  util::os::CheckProxyEnvironmentVariable();
   g_server = std::make_unique<Craned::CranedServer>(g_config.ListenConf);
   std::this_thread::sleep_for(std::chrono::milliseconds(500));
 

diff --git a/src/Utilities/PublicHeader/OS.cpp b/src/Utilities/PublicHeader/OS.cpp
@@ -111,6 +111,31 @@ bool SetMaxFileDescriptorNumber(unsigned long num) {
   return setrlimit(RLIMIT_NOFILE, &rlim) == 0;
 }
 
+bool CheckProxyEnvironmentVariable() {
+  bool has_proxy = false;
+  const char* HTTP_PROXY = std::getenv("HTTP_PROXY");
+  if (HTTP_PROXY) {
+    has_proxy = true;
+    CRANE_WARN("HTTP_PROXY is set to {}", HTTP_PROXY);
+  }
+  const char* http_proxy = std::getenv("http_proxy");
+  if (http_proxy) {
+    has_proxy = true;
+    CRANE_WARN("http_proxy is set to {}", http_proxy);
+  }
+  const char* HTTPS_PROXY = std::getenv("HTTPS_PROXY");
+  if (HTTPS_PROXY) {
+    has_proxy = true;
+    CRANE_WARN("HTTPS_PROXY is set to {}", HTTPS_PROXY);
+  }
+  const char* https_proxy = std::getenv("https_proxy");
+  if (https_proxy) {
+    has_proxy = true;
+    CRANE_WARN("https_proxy is set to {}", https_proxy);
+  }
+  return has_proxy;
+}
+
 bool GetSystemReleaseInfo(SystemRelInfo* info) {
 #if defined(__linux__) || defined(__unix__)
   utsname utsname_info{};

diff --git a/src/Utilities/PublicHeader/include/crane/OS.h b/src/Utilities/PublicHeader/include/crane/OS.h
@@ -60,6 +60,8 @@ bool SetMaxFileDescriptorNumber(unsigned long num);
 
 bool GetSystemReleaseInfo(SystemRelInfo* info);
 
+bool CheckProxyEnvironmentVariable();
+
 absl::Time GetSystemBootTime();
 
 }  // namespace os