optimize batch hold/release (#394)

Co-authored-by: NamelessOIer <70872016+NamelessOIer@users.noreply.github.com>
PKUHPC · Dec 11, 2024 · 8312949 · 8312949
1 parent d85f41a
commit 8312949
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/CraneCtld/CtldGrpcServer.cpp b/src/CraneCtld/CtldGrpcServer.cpp
@@ -201,8 +201,14 @@ grpc::Status CraneCtldServiceImpl::ModifyTask(
     }
   } else if (request->attribute() == ModifyTaskRequest::Hold) {
     int64_t secs = request->hold_seconds();
+    std::vector<std::pair<task_id_t, std::future<CraneErr>>> results;
+    results.reserve(request->task_ids().size());
     for (auto task_id : request->task_ids()) {
-      err = g_task_scheduler->HoldReleaseTaskAsync(task_id, secs).get();
+      results.emplace_back(
+          task_id, g_task_scheduler->HoldReleaseTaskAsync(task_id, secs));
+    }
+    for (auto &[task_id, res] : results) {
+      err = res.get();
       if (err == CraneErr::kOk) {
         response->add_modified_tasks(task_id);
       } else if (err == CraneErr::kNonExistent) {