Separate Authentication and Modification in AccountManager #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huerni
force-pushed
the
dev/account_auth
branch
from
08e61f2 to
25965c2
Compare
huerni
force-pushed
the
dev/account_auth
branch
from
36c2993 to
7856f0c
Compare
RileyWen
requested changes
Sep 20, 2024
RileyWen
reviewed
Sep 25, 2024
huerni
force-pushed
the
dev/account_auth
branch
2 times, most recently
from
9e44d6c to
f00079c
Compare
huerni
force-pushed
the
dev/account_auth
branch
from
6f3801f to
df4e21b
Compare
RileyWen
reviewed
Oct 24, 2024
L-Xiafeng
reviewed
Oct 25, 2024
L-Xiafeng
reviewed
Oct 25, 2024
L-Xiafeng
reviewed
Oct 25, 2024
L-Xiafeng
reviewed
Oct 25, 2024
L-Xiafeng
reviewed
Oct 25, 2024
huerni
force-pushed
the
dev/account_auth
branch
from
fe368ef to
58bae2e
Compare
|
我没啥问题了。但是函数返回值，现在这样其实和直接返回一个int没区别，std::expected好像有点多余，看 @RileyWen 有没有什么意见？ |
|
我明天看下 |
RileyWen
requested changes
Nov 1, 2024
RileyWen
force-pushed
the
dev/account_auth
branch
from
91ffce0 to
0aaa377
Compare
RileyWen
reviewed
Nov 4, 2024
RileyWen
reviewed
Nov 4, 2024
RileyWen
reviewed
Nov 4, 2024
RileyWen
reviewed
Nov 4, 2024
RileyWen
requested changes
Nov 4, 2024
RileyWen
reviewed
Nov 4, 2024
RileyWen
reviewed
Nov 4, 2024
RileyWen
reviewed
Nov 4, 2024
RileyWen
reviewed
Nov 4, 2024
…HasPemOnUser CheckIfUserHasPemOnUser
Remove useless changes
Signed-off-by: RileyW <wrllrwwrllrw@gmail.com>
RileyWen
force-pushed
the
dev/account_auth
branch
from
d3bcf1b to
b941552
Compare
huerni
added a commit
that referenced
this pull request
Jan 7, 2025
* feat: separate adduser addaccount and addqos * feat: separate AM add partition and qos * feat: Standardize item in proto and rename it to modifyField * fix: CheckAddUserAllowedQos check qos already in user allowed * feat: modifyUser overwrite * refactor: Replace pointer parameters with references * feat: modifyuser delete * feat: delete user and fix delete user in default account(bug 179) * feat: deleteAccount deleteQos * feat: modifyAccount * fix: Cannot modify partition and qos simultaneously * feat: blockuser blockaccount * feat: refactor QueryUser QueryAccount QueryQos * feat: refactor modifyUser * feat: refactor blockaccount blockuser * fix: modifyUserdefaultqos * feat: CheckPartitionIsAllowed CheckQosIsAllowed * fix: fix modify adminLevel, new_level must <= op_level * fix: modify qos modifyField error * fix: adduser Check whether the account exists * fix: addcount opuser existed and account empty bug * fix: CheckOpUserHasPermissionToAccount * fix: simultaneous modification conflict * feat: Return front-end error code demo. * feat:fix CheckSetUserAllowedQos No result returned issue. * feat: update err code * feat: Error Code Specification * merge Add display of coordinator field (#180) * feat: To upgrade to C++23, use std::expected and std::unreachable. * feat: update errCode * delete tl expected head file * fix: errCode * fix: add ERR_PARENT_ALLOWED_ err code * fix: ERR_USER_EMPTY_PARTITION * fix: set account qos err code * refactor * refactor * refactor * refactor * refactor * refactor * refactor * refactor: unused-parameters * refactor: CraneExpected<bool> to CraneExpected<void> * refactor * refactor Signed-off-by: RileyW <wrllrwwrllrw@gmail.com> * refactor * refactor: CheckIfUserHasPemOnUser CheckIfUserHasPemOnUser CheckIfUserHasPemOnUser CheckIfUserHasPemOnUser * refactor: HasPermissionToUser * Refactor. Signed-off-by: RileyW <wrllrwwrllrw@gmail.com> * fix: double locking * refactor * refactor * fix: AddAccount * Update PublicDefs.proto Remove useless changes * fix: The default QoS setting was missed when adding the account. * refactor * Reformat cmake. Signed-off-by: RileyW <wrllrwwrllrw@gmail.com> --------- Signed-off-by: RileyW <wrllrwwrllrw@gmail.com> Co-authored-by: RileyW <wrllrwwrllrw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.