fix: Fix sigsegv in cranectld #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Xiafeng
changed the title
m_pending_task_map_ entry not erased. Signed-off-by: Li Junlin <xiafeng.li@foxmail.com>
add lock to avoid data race Signed-off-by: Li Junlin <xiafeng.li@foxmail.com>
RileyWen
force-pushed
the
bugfix/sigsegv
branch
from
3772641 to
50902c6
Compare
RileyWen
approved these changes
Nov 20, 2024
huerni
pushed a commit
that referenced
this pull request
Jan 7, 2025
* fix: fix sigsegv in cranectld m_pending_task_map_ entry not erased. Signed-off-by: Li Junlin <xiafeng.li@foxmail.com> * fix: Data race in ConnectCranedNode_ add lock to avoid data race Signed-off-by: Li Junlin <xiafeng.li@foxmail.com> * Refactor. Signed-off-by: RileyW <wrllrwwrllrw@gmail.com> --------- Signed-off-by: Li Junlin <xiafeng.li@foxmail.com> Signed-off-by: RileyW <wrllrwwrllrw@gmail.com> Co-authored-by: RileyW <wrllrwwrllrw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_pending_task_map_ entry not erased.