Add specific reasons for failed task submission #375
+381
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
1daidai1
commented
Nov 26, 2024
•
1daidai1
commented
Nativu5
reviewed
Nov 27, 2024
RileyWen
reviewed
Nov 28, 2024
|
这块之前特意就写的不用string了 一边在errcode化 怎么这边还开始返祖了 |
|
如果不想这么改的话那我多增加几个枚举值吧，将参数错误这个枚举细化多几个枚举值 |
1daidai1
force-pushed
the
dev/addsubmitreason
branch
from
b65d967 to
1970f99
Compare
Closed
1daidai1
force-pushed
the
dev/addsubmitreason
branch
3 times, most recently
from
b382e40 to
2d88fb3
Compare
1daidai1
force-pushed
the
dev/addsubmitreason
branch
from
1e858c5 to
52eedd7
Compare
|
先基于 Master 分支 rebase 一下吧。 |
1daidai1
force-pushed
the
dev/addsubmitreason
branch
from
52eedd7 to
bf52d55
Compare
RileyWen
reviewed
Dec 12, 2024
| @@ -147,12 +151,86 @@ constexpr std::array<std::string_view, uint16_t(CraneErr::__ERR_SIZE)> | |||
| "Not enough nodes which satisfy resource requirements", | |||
| }; | |||
|
|
|||
| const std::unordered_map<crane::grpc::ErrCode, std::string_view> ErrCodeStrMap = { | |||
There was a problem hiding this comment.
ERR_INVALID_UID这边开始整体offset改小 然后用array存 做成直接寻址查找
1daidai1
force-pushed
the
dev/addsubmitreason
branch
from
a984104 to
047b895
Compare
1daidai1
force-pushed
the
dev/addsubmitreason
branch
from
1c01ff4 to
5358681
Compare
|
代码已提交 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.