게시글 삭제 기능 구현 및 BoardBottomSheet 추상화 #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
공지 UI에서도 게시글 UI와 같은 디자인과 기능을 공유하기 때문에, 새롭게 기능을 구현하는 것 보다 기존의 코드를 재사용 하는 것이 유지보수 측면에서 더 낫다고 판단했습니다. 그래서 게시글 코드 내에 BoardBottomSheetVC를 직접 호출하는 곳이 있었는데, 공지에서도 바텀시트를 따로 사용해야하기 때문에 이를 추상화할 필요가 있었습니다. 그래서 BoardBottomSheetViewControllerType이라는 프로토콜을 ViewModel을 만들 때 파라미터로 받도록 구현하여, ViewModel과 ViewController는 어떤 바텀시트가 들어오든 상관없이 직접 생성하여 호출하는 식으로 처리하였습니다.
WhiteHyun
added
😎 Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
BoardBottomSheetViewControllerType을 추가BoardBottomSheetViewControllerType를 인자로 받으며, 나중에 공지를 구현하게 된다면BoardBottomSheetViewControllerType을 준수(conform)하는AnnouncementBottomSheetViewController를 넣을 예정입니다.📸 스크린샷
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-13.at.19.38.09.mp4
📮 관련 이슈