Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update board_types.txt #236

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Update board_types.txt #236

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3db58f9
Update board_types.txt
ZeroOne-Aero Aug 1, 2024
7964861
Update board_types.txt
ZeroOne-Aero Aug 2, 2024
b4384fe
Update board_types.txt
ZeroOne-Aero Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions board_types.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ Reserved "NXP ucans32k146" 34
Reserved "NXP FMURT1170-V1" 35 # AKA PX4 FMU V6XRT
Reserved "NXP Tropic" 36

Reserved “ZEROONE_X6" 101
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want one entry - so delete this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean we only need to add the following sentences?
#IDs 5600-5699 reserved for ZeroOne
AP_HW_ZeroOne_X6 5600
AP_HW_ZeroOne_PMU 5601
AP_HW_ZeroOne_GNSS 5602

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,I have removed this line:
Reserved “ZEROONE_X6" 101

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davids5 Do you think the modified version is OK?


# values from external vendors
EXT_HW_RADIOLINK_MINI_PIX 3

Expand Down Expand Up @@ -206,6 +208,11 @@ AP_HW_CUBEBLACK_PERIPH 1401
AP_HW_PIXRACER_PERIPH 1402
AP_HW_SWBOOMBOARD_PERIPH 1403

#IDs 5600-5699 reserved for ZeroOne
AP_HW_ZeroOne_X6 5600
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is AP_HW_ZeroOne_X6 and ZEROONE_X6 the same board? If so since you already have the AP id in Ardupilot, just add it here. Do not "Create" Ardupilot ID here that do not exist in Ardupilot yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this line already exists in the Ardupilot.

AP_HW_ZeroOne_PMU 5601
AP_HW_ZeroOne_GNSS 5602
Comment on lines +211 to +212
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
AP_HW_ZeroOne_PMU 5601
AP_HW_ZeroOne_GNSS 5602
AP_HW_ZeroOne_PMU 5601
AP_HW_ZeroOne_GNSS 5602

Add to AP first then document here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these two lines have been added to the Ardupilot.


# OpenDroneID enabled boards. Use 10000 + the base board ID
AP_HW_CubeOrange_ODID 10140
AP_HW_Pixhawk6_ODID 10053