Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug of comments which may misguide users #2520

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Feng1909
Copy link

@Feng1909 Feng1909 commented Sep 4, 2024

PR types(PR类型)

Doc

Description

VisDetectionhas been changed from fastdeploy::vision::Visualize::VisDetection to fastdeploy::vision::VisDetection, but when using

fastdeploy::vision::Visualize::VisDetection(Img, result_left, 0.5);

The terminal will show:

[WARNING] fastdeploy/vision/visualize/detection.cc(294)::VisDetection	DEPRECATED: fastdeploy::vision::Visualize::VisDetection is deprecated, please use fastdeploy::vision:VisDetection function instead.

Which fastdeploy::vision:VisDetection should be fastdeploy::vision::VisDetection.
There is a ':' mark missing.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants