Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use pagerduty-specific moduleId #6

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: use pagerduty-specific moduleId #6

merged 1 commit into from
Apr 22, 2024

Conversation

brianphillips
Copy link
Contributor

@brianphillips brianphillips commented Apr 19, 2024 •
edited by t1agob
Loading

Description

The previous value (custom-extensions) conflicts with the example value from the backstage documentation for writing custom actions. This value should be specific to this module.

Issue number: N/A

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@brianphillips
Use pagerduty-specific moduleId
f66f560 
The previous value (custom-extensions) conflicts with the example value from the [backstage documentation for writing custom actions](https://backstage.io/docs/features/software-templates/writing-custom-actions#register-action-with-new-backend-system). This value should be specific to this module.
@brianphillips brianphillips changed the title fix: Use pagerduty-specific moduleId fix: use pagerduty-specific moduleId Apr 19, 2024
@t1agob t1agob self-assigned this Apr 22, 2024
@t1agob t1agob changed the base branch from main to next April 22, 2024 08:51
t1agob
t1agob approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@t1agob t1agob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally and works as expected. Approved!

@t1agob t1agob merged commit df69b99 into PagerDuty:next Apr 22, 2024
1 check passed
@brianphillips brianphillips deleted the patch-1 branch April 22, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t1agob t1agob t1agob approved these changes

Assignees

@t1agob t1agob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianphillips @t1agob