Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some notes #166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adding some notes #166

wants to merge 2 commits into from

Conversation

subrama6
Copy link

No description provided.

@subrama6 subrama6 requested a review from rafusel June 13, 2022 17:04
README.md Outdated
on a Mac.
on a Mac
# Notes
- If PagerDuty Agent loses connectivity for whatever reason,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be good to state that regardless of if the agent loses network connectivity then the events are added to the local queue. Then we can state that if the agent loses network connectivity events in the queue will fail to send, are retried and stored according to the agent's retry logic. Depending on how long the network issues persist they may be pushed out automatically, if the event is still being retried.

On another note, events that are rate limited will be retried in perpetuity until the event is successfully delivered, or the event receives a 5XX error code in which case the retry logic kicks in.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For prolonged network outages events can be manually retried https://support.pagerduty.com/docs/pagerduty-agent-integration-guide#manage-the-queue

@subrama6 subrama6 requested a review from rafusel June 14, 2022 19:48
Copy link

@rafusel rafusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants