add valid test case for names format validation

PagerDuty · Aug 21, 2023 · 5fe6ebd · 5fe6ebd
1 parent 3a6043b
commit 5fe6ebd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pagerduty/resource_pagerduty_escalation_policy_test.go b/pagerduty/resource_pagerduty_escalation_policy_test.go
@@ -120,6 +120,12 @@ func TestAccPagerDutyEscalationPolicy_FormatValidation(t *testing.T) {
  Providers: testAccProviders,
  CheckDestroy: testAccCheckPagerDutyEscalationPolicyDestroy,
  Steps: []resource.TestStep{
+ // Just a valid name
+ {
+ Config: testAccCheckPagerDutyEscalationPolicyConfig(username, email, "SRE Escalation Policy"),
+ PlanOnly: true,
+ ExpectNonEmptyPlan: true,
+ },
  // Blank Name
  {
  Config: testAccCheckPagerDutyEscalationPolicyConfig(username, email, ""),

diff --git a/pagerduty/resource_pagerduty_service_test.go b/pagerduty/resource_pagerduty_service_test.go
@@ -141,6 +141,12 @@ func TestAccPagerDutyService_FormatValidation(t *testing.T) {
  Providers: testAccProviders,
  CheckDestroy: testAccCheckPagerDutyServiceDestroy,
  Steps: []resource.TestStep{
+ // Just a valid name
+ {
+ Config: testAccCheckPagerDutyServiceConfig(username, email, escalationPolicy, "DB Technical Service"),
+ PlanOnly: true,
+ ExpectNonEmptyPlan: true,
+ },
  // Blank Name
  {
  Config: testAccCheckPagerDutyServiceConfig(username, email, escalationPolicy, ""),