update max number of iddle conns in client transport

PagerDuty · Aug 16, 2024 · 906fe59 · 906fe59
1 parent a944382
commit 906fe59
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/pagerduty/config.go b/pagerduty/config.go
@@ -79,6 +79,14 @@ func (c *Config) Client() (*pagerduty.Client, error) {
  httpClient.Timeout = 2 * time.Minute
 
  transport := http.DefaultTransport.(*http.Transport).Clone()
+ // Set the maximum number of idle (keep-alive) connections across all hosts
+ // Experimenting with these values to see if it helps with the connection pool
+ // and hence to solve the issue
+ // https://github.com/PagerDuty/terraform-provider-pagerduty/issues/904
+ transport.MaxIdleConns = 0
+ transport.MaxIdleConnsPerHost = 500
+ transport.MaxConnsPerHost = 0
+
  if c.InsecureTls {
  transport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
  }
@@ -142,8 +150,17 @@ func (c *Config) SlackClient() (*pagerduty.Client, error) {
 
  var httpClient *http.Client
  httpClient = http.DefaultClient
+ httpClient.Timeout = 2 * time.Minute
 
  transport := http.DefaultTransport.(*http.Transport).Clone()
+ // Set the maximum number of idle (keep-alive) connections across all hosts
+ // Experimenting with these values to see if it helps with the connection pool
+ // and hence to solve the issue
+ // https://github.com/PagerDuty/terraform-provider-pagerduty/issues/904
+ transport.MaxIdleConns = 0
+ transport.MaxIdleConnsPerHost = 500
+ transport.MaxConnsPerHost = 0
+
  if c.InsecureTls {
  transport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
  }

diff --git a/pagerdutyplugin/config.go b/pagerdutyplugin/config.go
@@ -79,6 +79,14 @@ func (c *Config) Client(ctx context.Context) (*pagerduty.Client, error) {
  httpClient.Timeout = 2 * time.Minute
 
  transport := http.DefaultTransport.(*http.Transport).Clone()
+ // Set the maximum number of idle (keep-alive) connections across all hosts
+ // Experimenting with these values to see if it helps with the connection pool
+ // and hence to solve the issue
+ // https://github.com/PagerDuty/terraform-provider-pagerduty/issues/904
+ transport.MaxIdleConns = 0
+ transport.MaxIdleConnsPerHost = 500
+ transport.MaxConnsPerHost = 0
+
  if c.InsecureTls {
  transport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
  }