Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attributes to data.pagerduty_users.users & data.pagerduty_user #719

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

mdb
Copy link
Contributor

@mdb mdb commented Jul 29, 2023

This seeks to address issue #718 and issue #720 by adding additional attributes to each user in the data.pagerduty_users.users list, as well as the data.pagerduty_user:

  • role
  • job_title
  • time_zone
  • description

Acceptance tests results...

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccDataSourcePagerDutyUser_Basic -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
=== RUN   TestAccDataSourcePagerDutyUser_Basic
--- PASS: TestAccDataSourcePagerDutyUser_Basic (20.74s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     24.458s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  (cached) [no tests to run]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccDataSourcePagerDutyUsers_Basic -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
=== RUN   TestAccDataSourcePagerDutyUsers_Basic
--- PASS: TestAccDataSourcePagerDutyUsers_Basic (31.29s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     31.706s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  (cached) [no tests to run]

@mdb mdb force-pushed the mdb/enhance-users-data-source branch from 2667cf7 to 476b723 Compare July 30, 2023 23:30
@mdb mdb changed the title add attributes to data.pagerduty_users.users add attributes to data.pagerduty_users.users & data.pagerduty_user Jul 30, 2023
@mdb mdb marked this pull request as ready for review July 30, 2023 23:32
@mdb mdb changed the title add attributes to data.pagerduty_users.users & data.pagerduty_user add attributes to data.pagerduty_users.users & data.pagerduty_user Jul 30, 2023
@bharling
Copy link

bharling commented Aug 1, 2023

👍 this would help us a lot

@bin3377
Copy link

bin3377 commented Nov 2, 2023

Any update on this pull request? We do have an issue #759 pending on this fix

mdb and others added 3 commits March 5, 2024 20:26
This seeks to address issue #718 by adding additional attributes to each
user in the `data.pagerduty_users.users` list.

Signed-off-by: Mike Ball <mikedball@gmail.com>
This addresses issue #720 and adds additional attributes to the
`data.pagerduty_user`:

* `role`
* `job_title`
* `time_zone`
* `description`

Signed-off-by: Mike Ball <mikedball@gmail.com>
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @mdb for enhancing this Data Source 🎉 💪🏽

@imjaroiswebdev imjaroiswebdev merged commit b3d48ab into PagerDuty:master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants