Specify the default country code for contact methods #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drastawi
force-pushed
the
drastawi-patch-1
branch
2 times, most recently
from
34be961
to
5b04972
Compare
imjaroiswebdev
force-pushed
the
drastawi-patch-1
branch
from
1e8aabe
to
58d403b
Compare
imjaroiswebdev
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Hey @drastawi thank you for this contribution. btw, I took to the liberty of replacing the Default You added, by a more convenient and appropriate setting for this case. Computed = true.
|
Hey @drastawi https://github.com/PagerDuty/terraform-provider-pagerduty/releases/tag/v3.1.1 shipped ✌🏽 Thanks again! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the default country code is not specified, the API will default to 1. It is creating a permanent diff if not specified in a provider.