Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TFPROVDEV-47] Address service dependency drift for external removals #741

Conversation

imjaroiswebdev
Copy link
Contributor

Add service dependency clean up after external removal, furthermore add test cases for validating patched case, additionally update pagerduty_service_dependency implementation to use context aware methods.

Test cases extended...

$ make testacc TESTARGS="-count=1 -run TestAccPagerDutyBusinessServiceDependency"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyBusinessServiceDependency -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyBusinessServiceDependency_Basic # 👈 Test case extended
--- PASS: TestAccPagerDutyBusinessServiceDependency_Basic (24.48s)
=== RUN   TestAccPagerDutyBusinessServiceDependency_Parallel
--- PASS: TestAccPagerDutyBusinessServiceDependency_Parallel (57.70s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   82.900s
$ make testacc TESTARGS="-count=1 -run TestAccPagerDutyTechnicalServiceDependency"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyTechnicalServiceDependency -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyTechnicalServiceDependency_Basic # 👈 Test case extended
--- PASS: TestAccPagerDutyTechnicalServiceDependency_Basic (25.67s)
=== RUN   TestAccPagerDutyTechnicalServiceDependency_Parallel
--- PASS: TestAccPagerDutyTechnicalServiceDependency_Parallel (65.41s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   91.762s

Add test cases for validating patched case, additionally update
`pagerduty_service_dependency` implementation to use context aware
methods.
@imjaroiswebdev imjaroiswebdev merged commit 804b00c into PagerDuty:master Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant