Fix #832 service_dependency breaks if dependent services are deleted externally #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspj
commented
Mar 18, 2024
|
@imjaroiswebdev sorry for pinging you directly, but this is a pretty critical bug for our organisation as it makes it really hard to recover cross-team/project dependencies and we have to manually patch the tfstate regularly Edit: I've also tried to escalate this issue with your support directly (about two weeks ago) to no avail so I'm at a loss of what to do to get this in. |
imjaroiswebdev
force-pushed
the
fix/service_dependency_recovery
branch
from
b17e852
to
6edbea9
Compare
imjaroiswebdev
approved these changes
Mar 26, 2024
|
Yass! Thank you so much, this has been a huge impediment for us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #832