Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(team membership): Allow 404 to propagate to avoid registering it in disassociated eps list #838

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix(team membership): Allow 404 to propagate to avoid registering it in disassociated eps list #838

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1c3b8f
Allow 404 errors to pass and not register in the dissasociated EPs
scohen-nd Mar 14, 2024
81cd631
Adjust based on comment
scohen-nd Mar 20, 2024
f768375
Make sure the err is not nill
scohen-nd Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pagerduty/resource_pagerduty_team_membership.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,9 @@ func dissociateEPsFromTeam(c *pagerduty.Client, teamID string, eps []string) ([]
time.Sleep(2 * time.Second)
return retry.RetryableError(err)
}
if err != nil && isErrCode(err, 404) {
return retry.NonRetryableError(err)
}
return nil
})
if retryErr != nil {
Expand Down
Loading