Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource and data source for Alert Grouping Setting #935

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add resource and data source for Alert Grouping Setting #935

merged 1 commit into from
Oct 11, 2024

Conversation

cjgajard
Copy link
Contributor

@cjgajard cjgajard commented Oct 4, 2024 •
edited
Loading 

=== RUN   TestAccPagerDutyAlertGroupingSetting_Basic
--- PASS: TestAccPagerDutyAlertGroupingSetting_Basic (28.62s)
=== RUN   TestAccPagerDutyAlertGroupingSetting_AppendService
--- PASS: TestAccPagerDutyAlertGroupingSetting_AppendService (29.55s)
=== RUN   TestAccPagerDutyAlertGroupingSetting_PopService
--- PASS: TestAccPagerDutyAlertGroupingSetting_PopService (30.34s)
=== RUN   TestAccPagerDutyAlertGroupingSetting_ContentBased_WithTimeWindow
--- PASS: TestAccPagerDutyAlertGroupingSetting_ContentBased_WithTimeWindow (17.42s)
=== RUN   TestAccPagerDutyAlertGroupingSetting_Time_WithTimeoutZero
--- PASS: TestAccPagerDutyAlertGroupingSetting_Time_WithTimeoutZero (16.44s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       123.476s

@cjgajard cjgajard force-pushed the tpf-alert-grouping-setting branch 2 times, most recently from 25034f4 to 966c3c7 Compare October 7, 2024 15:13
imjaroiswebdev
imjaroiswebdev approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @cjgajard! 🏆 There are a good amount of users waiting for this to be released to tested 💪🏽 Thank you!

@imjaroiswebdev imjaroiswebdev merged commit 58906ac into PagerDuty:master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjaroiswebdev imjaroiswebdev imjaroiswebdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjgajard @imjaroiswebdev