-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated documentation for adding additional io #218
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor suggestions..
@@ -82,6 +84,12 @@ configuration. | |||
If the ``extension`` field is present then the ``extensions`` directory in the | |||
module must exist and contain a python server extension file. | |||
|
|||
If the ``extra_interface`` field is present then this block would enable use of | |||
the specified io. This io would also need to have been identified as a capability | |||
and signified with a '*' in the :ref:`Target ini`. THe build system would then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THe => The
and signified with a '*' in the :ref:`Target ini`. THe build system would then | ||
enable this io as if it were specified in the ``io`` section of the target.ini, | ||
up to the lower numer specified here or in the target.ini. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where the number of instances is determined by the lower of the number specified here or that given in the target.ini file.
|
||
The ``io`` type describes the IO that is available on the target. The format is | ||
``io_name: io_type, number``. If ``io_type`` is not specified it is assumed | ||
to be the same as ``io_name``. If there is a '*' in ``number`` the target has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a '*' following number
@@ -284,12 +292,20 @@ The first entry to the ini file defines information for the SFP sites for the | |||
target:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, change 'SFP' to 'IO' in
The [.] section
~~~~~~~~~~~~~~~
The first entry to the ini file defines information for the SFP sites for the
I think it is okay, though a few minor suggestions above. Might be better though to get somebody not familiar with the changes to review and see if it is understandable. |
resolves #193.
@glennchid Would you say this description is easy to follow? I'm wondering if it doesn't read that well - I'm happy to re-write it.