fix: make param mappings properly optional #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also makes the report cli param optional
MiniDigger
commented
Mar 8, 2024
| @@ -74,7 +74,7 @@ static final class ReportOptions { | |||
| hidden = true) | |||
| private @Nullable Path reportsDir; | |||
|
|
|||
| @CommandLine.ArgGroup(multiplicity = "1") | |||
| @CommandLine.ArgGroup(multiplicity = "1", exclusive = false) | |||
There was a problem hiding this comment.
@DenWav idk how much experience you have with this cli stuff, but if I dont add this, I get a weird error about missing args (like its missing (()) )
turned on debug logging for it, said something about making stuff required because its not exclusive and did that, but idk what effect this has, stuff seems to work tho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also makes the report cli param optional