Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in the Language enum #29

Closed
wants to merge 1 commit into from
Closed

Fix typo in the Language enum #29

wants to merge 1 commit into from

Conversation

PythonCoderAS
Copy link
Contributor

The HongKong constant was named CHINEESE_HONGKONG = "hk", where CHINEESE is a typo of CHINESE. This PR will fix this typo, but this does create a breaking change.

@AdrienSeon
Copy link

Yeah, we have this issue open on this #27
We will try to correct all of this in the next extensions-common release geared for 0.6.0 since it's a breaking change.
We are waiting for Paperback to be completely separated from Mangadex app side since those enums where from Mangadex at first to create our own Paperback enums for our own purposes.

@PythonCoderAS
Copy link
Contributor Author

I deleted the repo that had this PR, so I'm going to close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PythonCoderAS @AdrienSeon