feat: release standups ai to all users #10724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dschoordsch
requested changes
Jan 23, 2025
There was a problem hiding this comment.
I have issues when ending a standup with one response. I get the following error
NotFoundError
The object can not be found here.
Call Stack
removeChild
[native code]:undefined:undefined
removeChild
:undefined:undefined
unmountHostComponents
:undefined:undefined
commitDeletion
:undefined:undefined
commitMutationEffects
:undefined:undefined
callCallback
:undefined:undefined
dispatchEvent
[native code]:undefined:undefined
invokeGuardedCallbackDev
:undefined:undefined
invokeGuardedCallback
:undefined:undefined
commitRootImpl
:undefined:undefined
Can you double check?
| } | ||
| }, | ||
|
|
||
| summary: ({summary}) => (summary === '<loading>' ? null : summary), |
There was a problem hiding this comment.
+1 we're using <loading> in more places now, so it could be worth it moving it into a constant
|
|
||
| if (!useAI || !hasAiApiKey || !hasContent(meeting)) return null | ||
|
|
||
| if (meeting.isLoadingSummary) return <WholeMeetingSummaryLoading /> |
There was a problem hiding this comment.
+1 WholeMeetingSummaryLoading contains invalid html
Warning: validateDOMNesting(...): <tr> cannot appear as a child of <td>.
tr
td
tr
WholeMeetingSummary
|
|
||
| if (meeting.isLoadingSummary) return <WholeMeetingSummaryLoading /> | ||
|
|
||
| return <WholeMeetingSummaryResult meetingRef={meeting} /> |
There was a problem hiding this comment.
+1 same invalid tr->td->tr nesting here. Would be nice if you could fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10696
This PR releases AI Standups to all users.
It also updates the loading UX for standups, so it works in the same way as retros, and it makes the
WholeMeetingSummarycode more concise.To test