Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syndicate Research Base Mega Fix Pack #27369

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

SchrodingersWolf
Copy link
Contributor

What Does This PR Do

Adds an APC to the Syndicate Research Base, allowing the lights outside to work again. Also added a maintenance closet to house said APC, as well as a plushie - Say hi to Forks-the-Outlet, the unsung hero of the Syndicate, maintainer of the Base! Fixes #27233

Adds two light fixtures to the Dressing Room as it is extremely dark in there.

Adds a Syndicate variant of the Claw Game with Freeplay enabled so Syndicate Researchers can waste their time gaming instead of conducting unethical experiments. Fixes #26687

Why It's Good For The Game

Let there be light, so the Researchers may be able to use their camera consoles to watch out for intruders and to make themselves look pretty in the Dressing Room.

Cute plushies are good.

Claw Game being usable by Syndies is good.

Images of changes

APC for exterior lights
Screenshot 2024-11-16 034955

New lights for Dressing Room
Screenshot 2024-11-16 045300

No screenshot for the Claw Game fix. Sorry.

Testing

It compiles.

Spawned in, checked that everything I changed did indeed change.

Spawned a bunch of skrells, turned off the new Syndicate Space Base Cave APC, verified that the turrets mowed down the skrells just fine.

Tried it again with a destroyed APC.

Checked Claw Game, verified Freeplay is on and that Syndicate Officers can enjoy the game.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Additional lights in the Syndicate Space Base Dressing Room
fix: Syndicate Space Base exterior lights now have an APC connected
fix: Syndicate Space Base now has a Syndicate variant of Claw Game which does not require credits or an account
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 16, 2024
@warriorstar-orion
Copy link
Contributor

@SchrodingersWolf could you merge to master and run UpdatePaths script 27386?

Copy link
Contributor

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions bot added the Stale This PR has been left inactive and requires an update. label Dec 17, 2024
@Burzah Burzah removed the Stale This PR has been left inactive and requires an update. label Dec 17, 2024
Copy link
Contributor

@silverplatedelta silverplatedelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Still needs a mapping pass.

@Bm0n
Copy link
Contributor

Bm0n commented Dec 30, 2024

It seems like the syndi claw game isn't mapped in the latest commit version

@SchrodingersWolf
Copy link
Contributor Author

It seems like the syndi claw game isn't mapped in the latest commit version

Resolved in latest commit

Copy link
Contributor

@FunnyMan3595 FunnyMan3595 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes to the station maps. If needed (and it probably is), that should be done as a separate PR. Probably by @warriorstar-orion , since it's his script that's adjusting them.

Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting stale, please adress requested changes or your PR will be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Map Edit This PR will modify a map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syndicate research base internal perimeter is not powered Syndie Researchers cannot use the claw machine
8 participants