Skip to content

Commit

Permalink
Better filter cities from CSV for adjective testing (#367)
Browse files Browse the repository at this point in the history
  • Loading branch information
IhateTrains authored Nov 2, 2023
1 parent 10ad92a commit 6952225
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion commonItems.UnitTests/Linguistics/StringExtensionsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,9 @@ public void AdjectiveRuleExistsForEveryCountryAndMajorCityInTheWorld() {
var csv = new WebClient().DownloadString(csvUrl);

Check warning on line 488 in commonItems.UnitTests/Linguistics/StringExtensionsTests.cs

View workflow job for this annotation

GitHub Actions / test_and_check_coverage

'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
var cities = CsvReader.ReadFromText(csv)
.Select(line => line[0])
.Where(city => !string.IsNullOrEmpty(city) && !city.StartsWith("Zürich (Kreis"))
.Where(city => !string.IsNullOrEmpty(city))
.Where(city => !city.StartsWith("Zürich (Kreis"))
.Where(city => !city.StartsWith("Sector "))
.Distinct()
.ToList();

Expand Down
2 changes: 1 addition & 1 deletion commonItems/commonItems.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<GeneratePackageOnBuild>False</GeneratePackageOnBuild>
<PackageId>PGCG.$(AssemblyName)</PackageId>
<Version>9.0.0</Version>
<Version>9.0.1</Version>
<Authors>PGCG</Authors>
<PackageProjectUrl>https://github.com/ParadoxGameConverters/commonItems.NET</PackageProjectUrl>
<RepositoryUrl>https://github.com/ParadoxGameConverters/commonItems.NET</RepositoryUrl>
Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "7.0.402",
"version": "7.0.403",
"rollForward": "disable"
}
}

0 comments on commit 6952225

Please sign in to comment.