Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonRegexes.Date: accept incomplete dates #430

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

IhateTrains
Copy link
Member

@IhateTrains IhateTrains commented May 1, 2024

CK3 has multiple instances of incomplete dates in character history. Some log lines from IRToCK3:

2024-05-01 15:03:12 [DEBUG] Ignored history keywords: 640.1.
2024-05-01 15:03:12 [DEBUG] Ignored history keywords: 889
2024-05-01 15:03:12 [DEBUG] Ignored history keywords: 1019.1.
2024-05-01 15:03:12 [DEBUG] Ignored history keywords: 1058.1.
2024-05-01 15:03:12 [DEBUG] Ignored history keywords: 1065.1.
2024-05-01 15:03:13 [DEBUG] Ignored history keywords: 1077.1
2024-05-01 15:03:13 [DEBUG] Ignored history keywords: 1101.1
2024-05-01 15:03:14 [DEBUG] Ignored history keywords: 976.1
2024-05-01 15:03:14 [DEBUG] Ignored history keywords: 880.1.1.
2024-05-01 15:03:14 [DEBUG] Ignored history keywords: 1049
2024-05-01 15:03:15 [DEBUG] Ignored history keywords: 939.1.
2024-05-01 15:03:15 [DEBUG] Ignored history keywords: 841.1.1.
2024-05-01 15:03:15 [DEBUG] Ignored history keywords: 1046
2024-05-01 15:03:15 [DEBUG] Ignored history keywords: 879.1.

@IhateTrains IhateTrains added the enhancement New feature or request label May 1, 2024
@IhateTrains IhateTrains requested review from Zemurin and Idhrendur May 1, 2024 17:26
@coveralls
Copy link

coveralls commented May 1, 2024

Pull Request Test Coverage Report for Build 8912899100

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 92.996%

Totals Coverage Status
Change from base Build 8877018128: 0.07%
Covered Lines: 3390
Relevant Lines: 3609

💛 - Coveralls

@IhateTrains IhateTrains marked this pull request as draft May 1, 2024 17:30
@IhateTrains
Copy link
Member Author

Reworked the Date constructor to accept incomplete dates. Ready for review again.

@IhateTrains IhateTrains marked this pull request as ready for review May 1, 2024 17:51
@IhateTrains IhateTrains requested review from Zemurin and Idhrendur May 1, 2024 17:51
@IhateTrains IhateTrains merged commit ba4b331 into main May 2, 2024
8 checks passed
@IhateTrains IhateTrains deleted the date-regex-tweak branch May 2, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants