-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag to exclude directories from filtering #35
base: master
Are you sure you want to change the base?
Conversation
@dolsem I decided to try Tauri, found this repository to implement the necessary functionality. I was very upset when I found this non-intuitive behavior. I'm waiting for your correction to be added |
I updated the PR renaming the flag to just |
I'd love to get feedback on the PR, if there is interest in merging it, I can update document this feature in the README as well. |
@dolsem There is a lot of interest. I am currently studying rust and tauri on my project using "Rust search" and your changes have helped me a lot in the project. |
@edwardgra4ev thank you, that's good to know. Hopefully there will be interest from maintainers as well, so that the PR can get merged. |
Hey guys, I created this repository solely to work as a search library for Verve. I'm working on other stuff currently and don't get much time to work on my open-source projects. I'll merge these changes. Thanks for the contribution @dolsem and sorry for the delay @edwardgra4ev . |
Hey @dolsem , the builds are failing. Can you have a look? |
@ParthJadhav I'll update it today. |
@ParthJadhav I fixed all the broken tests |
@ParthJadhav any update? |
Currently if you apply filters to search it will ignore everything inside a directory that does not match a filter. So if you, for example. want to recursively find all files in the tree that have been modified today, it won't work. This is expect behavior of
filter_entry()
, see here.This PR adds a flag to prevent applying filters to directories and only look at the files.