Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Visitor's Logbook Stats #246

Conversation

RayDeeUx
Copy link
Contributor

@RayDeeUx RayDeeUx commented Oct 15, 2023

2023-10-15_13 52 30

@Su386yt
Copy link
Member

Su386yt commented Oct 16, 2023

Are we gonna make it so it saves all the data?

@j10a1n15
Copy link
Collaborator

Are we gonna make it so it saves all the data?

I dont think thats needed since the data is only displayed per page

@Su386yt
Copy link
Member

Su386yt commented Oct 16, 2023

Wait so then what is the feature?

@j10a1n15
Copy link
Collaborator

This feature gets the lore and counts them up

@Su386yt
Copy link
Member

Su386yt commented Oct 16, 2023

There has to be a better way to format that

@RayDeeUx
Copy link
Contributor Author

There has to be a better way to format that

i could make a new mode where everything's line split like follows:

[RARITY]
— VISITED
— ACCEPTED
— PENDING OR DENIED

since there's still a fuckton of empty space

@j10a1n15
Copy link
Collaborator

Unknown feels kinda weird, you could maybe make it so unknown only gets shown when there actually is one unknown, while the other rarities get shown all the time

@j10a1n15
Copy link
Collaborator

Could you please add a new screenshot when your formatting is done? Thank you~

@RayDeeUx
Copy link
Contributor Author

in class juggling skyhanni code give me a solid two hours

@RayDeeUx
Copy link
Contributor Author

:ezclap:

2023-10-16_13 25 37
2023-10-16_13 25 29
2023-10-16_13 25 34

@Su386yt
Copy link
Member

Su386yt commented Oct 16, 2023

Please tell me the chroma text is light gray by default

@j10a1n15
Copy link
Collaborator

I like it very much, also is this a leak of some new skyhanni feauture?

@RayDeeUx
Copy link
Contributor Author

I like it very much, also is this a leak of some new skyhanni feauture?

stack size, not rly a leak so much as it was me posting every progress on it inside the publicly accessible coding channel in skyhanni discord

Copy link
Collaborator

@j10a1n15 j10a1n15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im fine with it now, up to su if smth needs changed

@Su386yt Su386yt self-requested a review October 17, 2023 18:15
@Su386yt Su386yt merged commit a56053a into PartlySaneStudios:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants