-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Visitor's Logbook Stats #246
Feature: Visitor's Logbook Stats #246
Conversation
RayDeeUx
commented
Oct 15, 2023
•
edited
Loading
edited
src/main/java/me/partlysanestudios/partlysaneskies/system/OneConfigScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/me/partlysanestudios/partlysaneskies/garden/VisitorLogbookStats.kt
Outdated
Show resolved
Hide resolved
src/main/java/me/partlysanestudios/partlysaneskies/garden/VisitorLogbookStats.kt
Show resolved
Hide resolved
Are we gonna make it so it saves all the data? |
I dont think thats needed since the data is only displayed per page |
Wait so then what is the feature? |
This feature gets the lore and counts them up |
src/main/java/me/partlysanestudios/partlysaneskies/garden/VisitorLogbookStats.kt
Outdated
Show resolved
Hide resolved
There has to be a better way to format that |
i could make a new mode where everything's line split like follows: [RARITY] since there's still a fuckton of empty space |
Unknown feels kinda weird, you could maybe make it so unknown only gets shown when there actually is one unknown, while the other rarities get shown all the time |
Could you please add a new screenshot when your formatting is done? Thank you~ |
in class juggling skyhanni code give me a solid two hours |
Please tell me the chroma text is light gray by default |
I like it very much, also is this a leak of some new skyhanni feauture? |
src/main/java/me/partlysanestudios/partlysaneskies/garden/VisitorLogbookStats.kt
Outdated
Show resolved
Hide resolved
src/main/java/me/partlysanestudios/partlysaneskies/garden/VisitorLogbookStats.kt
Outdated
Show resolved
Hide resolved
src/main/java/me/partlysanestudios/partlysaneskies/garden/VisitorLogbookStats.kt
Outdated
Show resolved
Hide resolved
stack size, not rly a leak so much as it was me posting every progress on it inside the publicly accessible coding channel in skyhanni discord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im fine with it now, up to su if smth needs changed