Code Cleanup #437
Merged
Code Cleanup #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
|
most of the changes seem to be about indentation, trailing commas, imports, line length, and using = instead of return in kotlin classes when possible |
j10a1n15
requested changes
Jul 7, 2024
.../me/partlysanestudios/partlysaneskies/features/dungeons/party/partymanager/PartyManager.java
Outdated
Show resolved
Hide resolved
...ysanestudios/partlysaneskies/features/dungeons/party/permpartyselector/PermPartyManager.java
Outdated
Show resolved
Hide resolved
...in/java/me/partlysanestudios/partlysaneskies/features/skills/SkillUpgradeRecommendation.java
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/PartlySaneSkies.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/commands/PSSCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/utils/SystemUtils.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/utils/geometry/orientation/Angle.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/utils/geometry/vectors/Point2d.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/utils/geometry/vectors/Range3d.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/utils/geometry/vectors/Range3d.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
j10a1n15
approved these changes
Jul 8, 2024
|
This pull request has conflicts, please resolve those before the pull request can be reviewed. |
# Conflicts: # src/main/kotlin/me/partlysanestudios/partlysaneskies/config/psconfig/Config.kt # src/main/kotlin/me/partlysanestudios/partlysaneskies/features/debug/CrystalHollowsGemstoneMapper.kt # src/main/kotlin/me/partlysanestudios/partlysaneskies/features/themes/ThemeManager.kt
# Conflicts: # src/main/java/me/partlysanestudios/partlysaneskies/features/skills/SkillUpgradeRecommendation.java # src/main/kotlin/me/partlysanestudios/partlysaneskies/utils/StringUtils.kt
|
Conflicts have been resolved! |
|
This pull request has conflicts, please resolve those before the pull request can be reviewed. |
|
Conflicts have been resolved! |
Su386yt
reviewed
Jul 24, 2024
src/main/kotlin/me/partlysanestudios/partlysaneskies/PartlySaneSkies.kt
Outdated
Show resolved
Hide resolved
Su386yt
requested changes
Jul 24, 2024
src/main/kotlin/me/partlysanestudios/partlysaneskies/config/OneConfigScreen.kt
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/data/skyblockdata/SkyblockPlayer.kt
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/features/economy/CoinsToBoosterCookies.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/features/discord/webhooks/WebhookMenu.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/PartlySaneSkies.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/features/skills/SkillUpgradeWebhook.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/render/gui/components/PSSButton.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/me/partlysanestudios/partlysaneskies/render/gui/components/PSSHorizontalCooldown.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/render/gui/components/PSSToggle.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/me/partlysanestudios/partlysaneskies/render/gui/hud/BannerRenderer.kt
Outdated
Show resolved
Hide resolved
Su386yt
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pressed the funny reformat code button on intellij and let it do its thing