Backend: Create and use PSSChatEvent #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
…d-miningevents' into backend/pss-chat # Conflicts: # src/main/kotlin/me/partlysanestudios/partlysaneskies/events/EventManager.kt
|
This pull request has conflicts, please resolve those before the pull request can be reviewed. |
…end/pss-chat # Conflicts: # src/main/kotlin/me/partlysanestudios/partlysaneskies/features/gui/hud/rngdropbanner/DropBannerDisplay.kt
|
Conflicts have been resolved! |
|
Could you merge upstream main just so I can see the changes easier? |
|
ty |
Su386yt
reviewed
Jul 24, 2024
|
|
||
| object PickaxeWarning { | ||
|
|
||
| private val pattern = Pattern.compile("(Mining Speed Boost|Pickobulus|Maniac Miner|Vein Seeker) is now available!") | ||
| private val pattern = "(Mining Speed Boost|Pickobulus|Maniac Miner|Vein Seeker|Hazardous Miner|Gemstone Infusion) is now available!".toPattern() |
There was a problem hiding this comment.
Not in this unrelated pr though
There was a problem hiding this comment.
Reason its a comment not a review
Su386yt
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies:
This Pull Request creates and uses the PSSChatEvent
This does not yet support event cancelling, which should come soon though once the whole event system will be reworked.