Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Button on OneConfig + Autocomplete for items + GUI Improvements #442

Merged
merged 15 commits into from
Jul 26, 2024
Merged

Filter Button on OneConfig + Autocomplete for items + GUI Improvements #442

merged 15 commits into from
Jul 26, 2024

Conversation

Su386yt
Copy link
Member

@Su386yt Su386yt commented Jul 25, 2024

image

  • Added button to open GUI to oneconfig menu

image

  • The entire item name can be clicked + some padding to remove it
  • Item names are coloured in the active filter section

image

  • Autocomplete for items

image

  • Pretty much every clickable aspect of the gui has some sort of feedback when hovered

All GUIs

  • PSS Buttons now have feed back when hovered
Recording.2024-07-25.161057.mp4

Su386yt added 4 commits July 25, 2024 13:51
@Su386yt
Added button to open GUI
7ac8766
@Su386yt
Autocomplete + small fixes
7c7b736 
Added feedback when hovering over certain parts
Changed colours
Made item names now have rarity color in the filter menu
You no longer have to aim for the tiny box when removing items
Renamed buttons
@Su386yt
Added text color feed back when hovering over buttons
5eb712a
@Su386yt
More hover feedback
7f0a46c
@Su386yt Su386yt requested a review from j10a1n15 July 25, 2024 23:11
@Su386yt
Copy link
Member Author

Su386yt commented Jul 25, 2024

Untitled.video.8.mp4

j10a1n15
j10a1n15 requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@j10a1n15 j10a1n15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the .pixel -> .scaledPixel changes because that makes the text look awful again
image

@Su386yt
Copy link
Member Author

Su386yt commented Jul 26, 2024

If we don't use .scaledPixels it doesn't work when we change screen sizes

@Su386yt Su386yt requested a review from j10a1n15 July 26, 2024 13:51
j10a1n15
j10a1n15 requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@j10a1n15 j10a1n15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
a few things

  • filter list & input both input needs the new, fixed size
  • the funny sword is going out of bounds (i am fully scrolled to the top)
  • items that dont include a single j are in this list

@Su386yt
Copy link
Member Author

Su386yt commented Jul 26, 2024

items that dont include a single j are in this list

It uses item id as well that way you could do "Dojo" can get all the belts
Ie: Brown Belt
Item id: DOJO_BROWN_BELT

@Su386yt Su386yt requested a review from j10a1n15 July 26, 2024 14:43
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before the pull request can be reviewed.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved!

@Su386yt Su386yt merged commit 140e304 into PartlySaneStudios:main Jul 26, 2024
2 checks passed
@Su386yt Su386yt deleted the rng-drop-filter-button branch July 26, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j10a1n15 j10a1n15 j10a1n15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Su386yt @j10a1n15