Skip to content

Commit

Permalink
Fix flamewood crash and Ancestral Bond interaction (#6499)
Browse files Browse the repository at this point in the history
* FIX: Flamewood crash

* FIX: Ancestral bond disabling Flamewood
  • Loading branch information
Paliak authored Aug 25, 2023
1 parent 6505c07 commit cd69491
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/Data/Skills/sup_str.lua
Original file line number Diff line number Diff line change
Expand Up @@ -2301,7 +2301,7 @@ skills["AvengingFlame"] = {
name = "Avenging Flame",
color = 1,
description = "Launches a fiery projectile high into the air, to drop on a target and deal area damage where it lands.",
skillTypes = { [SkillType.Spell] = true, [SkillType.Damage] = true, [SkillType.Area] = true, [SkillType.AreaSpell] = true, [SkillType.Fire] = true, [SkillType.ProjectileNumber] = true, [SkillType.ProjectileSpeed] = true, [SkillType.Triggerable] = true, [SkillType.SkillGrantedBySupport] = true, [SkillType.Triggered] = true, [SkillType.InbuiltTrigger] = true, },
skillTypes = { [SkillType.Spell] = true, [SkillType.Damage] = true, [SkillType.Area] = true, [SkillType.AreaSpell] = true, [SkillType.Fire] = true, [SkillType.ProjectileNumber] = true, [SkillType.ProjectileSpeed] = true, [SkillType.Triggerable] = true, [SkillType.SkillGrantedBySupport] = true, [SkillType.Triggered] = true, [SkillType.InbuiltTrigger] = true, [SkillType.SummonsTotem] = true, },
statDescriptionScope = "debuff_skill_stat_descriptions",
castTime = 1,
preDamageFunc = function(activeSkill, output)
Expand Down
1 change: 1 addition & 0 deletions src/Export/Skills/sup_str.txt
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ local skills, mod, flag, skill = ...
},
#mods

#addSkillTypes SummonsTotem
#skill AvengingFlame
preDamageFunc = function(activeSkill, output)
local uuid = activeSkill.skillData.triggerSourceUUID
Expand Down
3 changes: 1 addition & 2 deletions src/Modules/CalcTriggers.lua
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,7 @@ local function defaultTriggerHandler(env, config)
end
end

if trigRate ~= nil and not actor.mainSkill.skillFlags.globalTrigger then
if trigRate ~= nil and not actor.mainSkill.skillFlags.globalTrigger and not actor.mainSkill.skillTypes[SkillType.InbuiltTrigger] then
output.EffectiveSourceRate = trigRate
else
output.EffectiveSourceRate = output.TriggerRateCap
Expand Down Expand Up @@ -1720,7 +1720,6 @@ local configTable = {
end
end,
["Avenging Flame"] = function(env)
env.player.mainSkill.skillFlags.globalTrigger = true
return {triggerSkillCond = function(env, skill) return skill.skillFlags.totem and slotMatch(env, skill) end,
comparer = function(uuid, source, currentTotemLife)
local totemLife = GlobalCache.cachedData["CACHE"][uuid].Env.player.output.TotemLife
Expand Down

0 comments on commit cd69491

Please sign in to comment.