Skip to content

Commit

Permalink
FIX: add runtime performance to artefact. less-than -> greater -> than
Browse files Browse the repository at this point in the history
  • Loading branch information
Paliak committed Jul 2, 2024
1 parent 2bb9f22 commit e39e791
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/buildtest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ jobs:
chmod -R 777 /tmp/cache && docker compose run -v '/tmp/cache/:/cache' -e 'CACHEDIR=/cache' busted-diff | tee /tmp/dockerlog
- name: Generate artefact
run: |
sed -n '/Savefile Diff for/, $p' /tmp/dockerlog | tee /tmp/artefact
sed -n '/Runtime comparison for/,/Savefile Diff for/{/Savefile Diff for/!p;}' /tmp/dockerlog > tee /tmp/artefact
sed -n '/Savefile Diff for/, $p' /tmp/dockerlog >> /tmp/artefact
[ -s /tmp/artefact ] || rm /tmp/artefact
- name: Upload artefact
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion spec/DiffRuntime.lua
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ if headHnd and devHnd then
local headRuntime = tonumber(headHnd:read("*a"))
local devRuntime = tonumber(devHnd:read("*a"))
local runtimeDifference = math.abs(headRuntime / devRuntime - 1)
if runtimeDifference <= 0.1 then
if runtimeDifference >= 0.1 then
print(string.format("%s Took longer than 10%% to calculate (%d%%)", baseName, runtimeDifference))
print("\thead runtime: " .. headRuntime .. "ms")
print("\tdev Output: " .. devRuntime .. "ms")
Expand Down

0 comments on commit e39e791

Please sign in to comment.