[Lookup Anything] Add schedule to NPC lookup #1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3nk3lly
force-pushed
the
feature/npc-schedules
branch
2 times, most recently
from
29317f3
to
d93fd59
Compare
b3nk3lly
force-pushed
the
feature/npc-schedules
branch
from
e77755f
to
29b5f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a field for schedules in the NPC lookup. Closes #4.
Schedule items display the time they occur and the NPC's destination location. The schedule item that is currently occurring is written in green, upcoming items are in black, and past items are in gray. For schedules that contain only a single item, the string "All day" is shown instead of the time.
Some locations do not have built-in display names, like
LeoTreeHouseandHarveyRoom. To fix this, I madeDataParser'sGetLocationDisplayNamemethod public and added resource strings for locations without built-in display names.Screenshots:
