Migrated the project to Kotlin #33

2307vivek · 2020-10-01T10:15:56Z

Summary

Migrated the whole project to use Kotlin as the primary language. This results in reduction of the codebase size, along with improved code readability.

Resolves #32

Build Dialogs with Kotlin DSL

Building dialogs is easier than ever with kotlin dsl.

Animated Material Dialog

val animatedMaterialDialog = materialDialog(this) {
    title = "Delete"
    message = "Are you sure you want to delete this file?"
    isCancelable = false
    setPositiveButton("Delete", R.drawable.ic_delete) { dialog, which ->
        Toast.makeText(applicationContext, "Deleted!", Toast.LENGTH_SHORT).show()
        dialog.dismiss()
    }
    setNegativeButton("Cancel", R.drawable.ic_close) { dialog, which ->
        Toast.makeText(applicationContext, "Cancelled!", Toast.LENGTH_SHORT).show()
        dialog.dismiss()
    }
    setAnimation("delete_anim.json")
}

Animated BottomSheetMaterialDialog

val animatedBottomSheetDialog = bottomSheetMaterialDialog(this) {
    title = "Delete"
    message = "Are you sure you want to delete this file?"
    isCancelable = false
    setPositiveButton("Delete", R.drawable.ic_delete) { dialog, which ->
        Toast.makeText(applicationContext, "Deleted!", Toast.LENGTH_SHORT).show()
        dialog.dismiss()
    }
    setNegativeButton("Cancel", R.drawable.ic_close) { dialog, which ->
        Toast.makeText(applicationContext, "Cancelled!", Toast.LENGTH_SHORT).show()
        dialog.dismiss()
    }
    setAnimation("delete_anim.json")
}

PatilShreyas · 2020-10-01T10:40:47Z

Thanks, @2307vivek for this PR 😃

2307vivek · 2020-10-01T11:05:07Z

Thanks, @2307vivek for this PR

@PatilShreyas My pleasure. 😀

PatilShreyas · 2020-10-01T10:49:11Z

MaterialDialogLibrary/src/main/java/com/shreyaspatil/MaterialDialog/DslBuilder.kt

+ */
+fun materialDialog(
+        activity: Activity,
+        block: MaterialDialog.Builder.() -> Unit


We can call it builder instead of block.

PatilShreyas · 2020-10-01T10:49:22Z

MaterialDialogLibrary/src/main/java/com/shreyaspatil/MaterialDialog/DslBuilder.kt

+ */
+fun bottomSheetMaterialDialog(
+        activity: Activity,
+        block: BottomSheetMaterialDialog.Builder.() -> Unit


Same as above

PatilShreyas · 2020-10-01T10:50:05Z

...rialDialogLibrary/src/main/java/com/shreyaspatil/MaterialDialog/BottomSheetMaterialDialog.kt

+    class Builder(private val activity: Activity) : DialogBuilder() {
+
+        /**
+         * Build the {@link BottomSheetMaterialDialog}.
+         */
+        fun build(): BottomSheetMaterialDialog =
+                BottomSheetMaterialDialog(activity, title, message, isCancelable, mPositiveButton, mNegativeButton, animationResId, mAnimationFile)
+    }
+}


This will hide builder pattern from Java. Right?

PatilShreyas · 2020-10-01T10:50:47Z

MaterialDialogLibrary/src/main/java/com/shreyaspatil/MaterialDialog/model/DialogBuilder.kt

+//    /**
+//     * @param title Sets the Title of Dialog.
+//     */
+//    fun setTitle(title: String) {
+//        mTitle = title
+//    }
+//
+//    /**
+//     * @param message Sets the Message of Dialog.
+//     */
+//    fun setMessage(message: String) {
+//        mMessage = message
+//    }
+//
+//    /**
+//     * @param isCancelable Sets cancelable property of Dialog.
+//     */
+//    fun isCancelable(isCancelable: Boolean) {
+//        cancelable = isCancelable
+//    }


What's purpose of this?

2307vivek · 2020-10-01T11:39:15Z

...rialDialogLibrary/src/main/java/com/shreyaspatil/MaterialDialog/BottomSheetMaterialDialog.kt

+    class Builder(private val activity: Activity) : DialogBuilder() {
+
+        /**
+         * Build the {@link BottomSheetMaterialDialog}.
+         */
+        fun build(): BottomSheetMaterialDialog =
+                BottomSheetMaterialDialog(activity, title, message, isCancelable, mPositiveButton, mNegativeButton, animationResId, mAnimationFile)
+    }
+}


This will hide builder pattern from Java. Right?

You cannot create a Dialog with builder pattern with my changes, but we need something to build the MaterialDialog class. The Builder class just collects data and builds the MaterialDialog class in the materialDialog() dsl function.

2307vivek · 2020-10-01T11:39:23Z

MaterialDialogLibrary/src/main/java/com/shreyaspatil/MaterialDialog/DslBuilder.kt

+ */
+fun materialDialog(
+        activity: Activity,
+        block: MaterialDialog.Builder.() -> Unit


We can call it builder instead of block.

Sure, calling it builder will make more sense.

2307vivek · 2020-10-01T11:42:42Z

MaterialDialogLibrary/src/main/java/com/shreyaspatil/MaterialDialog/model/DialogBuilder.kt

+//    /**
+//     * @param title Sets the Title of Dialog.
+//     */
+//    fun setTitle(title: String) {
+//        mTitle = title
+//    }
+//
+//    /**
+//     * @param message Sets the Message of Dialog.
+//     */
+//    fun setMessage(message: String) {
+//        mMessage = message
+//    }
+//
+//    /**
+//     * @param isCancelable Sets cancelable property of Dialog.
+//     */
+//    fun isCancelable(isCancelable: Boolean) {
+//        cancelable = isCancelable
+//    }


What's purpose of this?

It can be safely deleted, I wrote that methods before the class was finalised.

PatilShreyas

Looks good 👍🏻

2307vivek added 4 commits September 30, 2020 19:35

updated dependencies and configured kotlin.

ad87605

updated dependencies and configured kotlin (library module).

5e92ae2

migrated the project to kotlin.

afdc790

migrated the project to kotlin.

1437814

2307vivek requested a review from PatilShreyas as a code owner October 1, 2020 10:15

PatilShreyas added the Hacktoberfest label Oct 1, 2020

PatilShreyas reviewed Oct 1, 2020

View reviewed changes

2307vivek commented Oct 1, 2020

View reviewed changes

small changes.

9840482

2307vivek requested a review from PatilShreyas October 2, 2020 02:43

PatilShreyas approved these changes Oct 2, 2020

View reviewed changes

PatilShreyas added the hacktoberfest-accepted label Oct 3, 2020

PatilShreyas mentioned this pull request Oct 9, 2020

Migrate project to Kotlin #34

Closed

PatilShreyas changed the base branch from master to dev/kotlin April 23, 2021 07:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrated the project to Kotlin #33

Migrated the project to Kotlin #33

2307vivek commented Oct 1, 2020

PatilShreyas commented Oct 1, 2020

2307vivek commented Oct 1, 2020 •

edited

Loading

PatilShreyas Oct 1, 2020

PatilShreyas Oct 1, 2020

PatilShreyas Oct 1, 2020

PatilShreyas Oct 1, 2020

2307vivek Oct 1, 2020

2307vivek Oct 1, 2020

2307vivek Oct 1, 2020

PatilShreyas left a comment

Migrated the project to Kotlin #33

Are you sure you want to change the base?

Migrated the project to Kotlin #33

Conversation

2307vivek commented Oct 1, 2020

Summary

Build Dialogs with Kotlin DSL

PatilShreyas commented Oct 1, 2020

2307vivek commented Oct 1, 2020 • edited Loading

PatilShreyas Oct 1, 2020

Choose a reason for hiding this comment

PatilShreyas Oct 1, 2020

Choose a reason for hiding this comment

PatilShreyas Oct 1, 2020

Choose a reason for hiding this comment

PatilShreyas Oct 1, 2020

Choose a reason for hiding this comment

2307vivek Oct 1, 2020

Choose a reason for hiding this comment

2307vivek Oct 1, 2020

Choose a reason for hiding this comment

2307vivek Oct 1, 2020

Choose a reason for hiding this comment

PatilShreyas left a comment

Choose a reason for hiding this comment

2307vivek commented Oct 1, 2020 •

edited

Loading