Improve mixer performance when gain is 0.0 #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special case of 1.0 was catered for, but 0.0 can also be treated as a special case by releasing the relevant input block without multiplying and adding its data - it would be all zeroes anyway. Saves about 0.033% CPU per connected zero-gain channel, on a Teensy 4.1. Interestingly, the 1.0 gain optimisation appears to have little effect for the same hardware; those DSP instructions must be really effective!
Here's some test code: