Minor change to re enable Compare mode and added POSMATCH control option.

[mjs513]

@PaulStoffregen
In a continuation of improving the QuadEncoder library @joepasquariello suggested a couple of additional changes.

1. Add a flag for what POSMATCH will do when counters match the specified value, see page 3169 OUTCTL for bit
2. changed name of the function call to reenable the Compare interrupt from resetCompareInterrupt to enableCompareInterrupt

Hopefully this is the last change. Other than these changes all seems to be working with the library.

[joepasquariello]

Mike, Thanks. The only other suggestion I had was to add a function to modify positionCompareValue, similar to write(), which modifies initial (current) position. I think that’s something a user is likely to want if the are using compare interrupts. Joe

…

On Dec 25, 2021, at 10:45 AM, Mike S ***@***.***> wrote:  @PaulStoffregen In a continuation of improving the QuadEncoder library @joepasquariello suggested a couple of additional changes. Add a flag for what POSMATCH will do when counters match the specified value, see page 3169 OUTCTL for bit changed name of the function call to reenable the Compare interrupt from resetCompareInterrupt to enableCompareInterrupt Hopefully this is the last change. Other than these changes all seems to be working with the library. You can view, comment on, or merge this pull request online at: #3 Commit Summary 52e0828 Flag added to control POSMATCH mode options. 2a4c69f Change resetCompareInterupt to enableCompareInterrupt 0372a0b Update README.md 5d2f2fe Update README.md File Changes (5 files) M QuadEncoder.cpp (8) M QuadEncoder.h (4) M README.md (68) M examples/QuadEncoder/QuadEncoder.ino (10) M examples/QuadEncoder_Interrupt_pins/QuadEncoder_Interrupt_pins.ino (3) Patch Links: https://github.com/PaulStoffregen/Teensy-4.x-Quad-Encoder-Library/pull/3.patch https://github.com/PaulStoffregen/Teensy-4.x-Quad-Encoder-Library/pull/3.diff — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

[mjs513]

Thanks Paul. Will get that incorporated either tonight or tomorrow. But definitely good idea.

[mjs513]

@PaulStoffregen
Went ahead and added a setCompareValue function to the library - update and tested the example QuadEncoder.ino sketch as well to demo it.

Got board so I went ahead and updated it now.

[joepasquariello]

Looks good, Mike. Did some testing of new flag and functions and all works as expected. Joe On 12/25/2021 1:43 PM, Mike S wrote: @PaulStoffregen Went ahead and added a setCompareValue function to the library - update and tested the example QuadEncoder.ino sketch as well to demo it. Got board so I went ahead and updated it now. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: ***@***.***> [ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#3 (comment)", "url": "#3 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

[PaulStoffregen]

Should I pull this in for 1.57-beta2 ?

[mjs513]

Yes please was going to post on the beta1 about the update but got sidetracked, which is inevitable. Was wondering about the this in audio as well: PaulStoffregen/Audio#419, pr is only for wav and raw files nothing else.