Fixing an issue with new payment status after paypal payment performi…

…ng and redirecting back to paypal.
Payum · Dec 16, 2015 · da13bb8 · da13bb8
1 parent ff957a4
commit da13bb8
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/Action/PaymentDetailsStatusAction.php b/Action/PaymentDetailsStatusAction.php
@@ -36,6 +36,13 @@ public function execute($request)
             }
         }
 
+        if (
+            false == $model['PAYERID'] &&
+            Api::CHECKOUTSTATUS_PAYMENT_ACTION_NOT_INITIATED == $model['CHECKOUTSTATUS']
+        ) {
+            $request->markPending();
+        }
+
         if (isset($model['CANCELLED'])) {
             $request->markCanceled();
 

diff --git a/Tests/Action/PaymentDetailsStatusActionTest.php b/Tests/Action/PaymentDetailsStatusActionTest.php
@@ -221,6 +221,24 @@ public function shouldMarkPendingIfCheckoutStatusInProgress()
         $this->assertTrue($request->isPending());
     }
 
+    /**
+     * @test
+     */
+    public function shouldMarkPendingIfPayerIdNotSetAndCheckoutStatusNotInitiated()
+    {
+        $action = new PaymentDetailsStatusAction();
+
+        $request = new GetHumanStatus(array(
+            'PAYMENTREQUEST_0_AMT' => 12,
+            'PAYERID' => null,
+            'CHECKOUTSTATUS' => Api::CHECKOUTSTATUS_PAYMENT_ACTION_NOT_INITIATED,
+        ));
+
+        $action->execute($request);
+
+        $this->assertTrue($request->isPending());
+    }
+
     /**
      * @test
      */