Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all packages back to dev mode after release #3335

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

infotroph
Copy link
Member

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add this to the web interface as well. See https://github.com/PecanProject/pecan/blob/develop/web/common.php#L17

otherwise quick glance LGTM

@@ -5,7 +5,7 @@ section for the next release.

For more information about this file see also [Keep a Changelog](http://keepachangelog.com/) .

## [1.8.0] - 2024-07-12
## [Unreleased]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing a merge error -- released material starts on line 23 and has the right heading already

@@ -14,7 +14,7 @@ function get_footer() {
Terrestrial Ecosystems, Department of Energy (ARPA-E #DE-AR0000594 and #DE-AR0000598),
Department of Defense, the Arizona Experiment Station, the Energy Biosciences Institute,
and an Amazon AWS in Education Grant.
<span style=\"float:right\">PEcAn Version 1.8.0</span>";
<span style=\"float:right\">PEcAn Version 1.8.0.9000</span>";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we might want to consider querying this from R so we don't have to remember to update it, but for today I'm happy bumping manually.

@infotroph infotroph enabled auto-merge July 13, 2024 17:44
@infotroph infotroph added this pull request to the merge queue Jul 13, 2024
Merged via the queue into PecanProject:develop with commit 949e12c Jul 13, 2024
13 checks passed
@infotroph infotroph deleted the versions-back-to-dev branch July 26, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants