Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Workflow improvements to run independently of BETY #3398

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

yinghaoSunn
Copy link

@yinghaoSunn yinghaoSunn commented Nov 22, 2024

Description

This draft Pull Request introduces changes to allow the LPJ-GUESS workflow to run independently of the BETY database. The main changes include:

  • Updated database connection logic to handle missing BETY settings.
  • Added fallback mechanisms for standalone workflow operation.

Feedback and further suggestions are welcome.

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Co-authored-by: Chris Black <chris@ckblack.org>
Re-add the `write <- settings$database$bety$write` that was mistakenly deleted earlier.
Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! this looks good and I'm happily building on it already for DB-free SIPNET runs.

modules/uncertainty/R/ensemble.R Outdated Show resolved Hide resolved
modules/uncertainty/R/get.parameter.samples.R Show resolved Hide resolved
yinghaoSunn and others added 3 commits December 27, 2024 19:49
Co-authored-by: Chris Black <chris@ckblack.org>
Re-add an empty line before the final statement in the get.parameter.samples function to align with common R style guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants